Skip to content

Add default params_to_tune for MedianOutliersTransform, DensityOutliersTransform and PredictionIntervalOutliersTransform #1231

Merged
merged 2 commits into from Apr 19, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 18, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1225.

Closing issues

Closes #1225.

…ityOutliersTransform, PredictionIntervalOutliersTransform
@Mr-Geekman Mr-Geekman self-assigned this Apr 18, 2023

class PredictionIntervalOutliersTransform(OutliersTransform):
"""Transform that uses :py:func:`~etna.analysis.outliers.prediction_interval_outliers.get_anomalies_prediction_interval` to find anomalies in data."""

def __init__(
self,
in_column: str,
model: Union[Type["ProphetModel"], Type["SARIMAXModel"]],
model: Union[Literal["prophet"], Literal["sarimax"], Type["ProphetModel"], Type["SARIMAXModel"]],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks somewhat like a hack. I don't think it is a good solution.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because categorical distribution can't work with this type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@28d8fb7). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             automl-2.0    #1231   +/-   ##
=============================================
  Coverage              ?   87.42%           
=============================================
  Files                 ?      166           
  Lines                 ?    10330           
  Branches              ?        0           
=============================================
  Hits                  ?     9031           
  Misses                ?     1299           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 18, 2023 15:24 Inactive

class PredictionIntervalOutliersTransform(OutliersTransform):
"""Transform that uses :py:func:`~etna.analysis.outliers.prediction_interval_outliers.get_anomalies_prediction_interval` to find anomalies in data."""

def __init__(
self,
in_column: str,
model: Union[Type["ProphetModel"], Type["SARIMAXModel"]],
model: Union[Literal["prophet"], Literal["sarimax"], Type["ProphetModel"], Type["SARIMAXModel"]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because categorical distribution can't work with this type?

@alex-hse-repository alex-hse-repository merged commit 68634b0 into automl-2.0 Apr 19, 2023
13 checks passed
@Mr-Geekman Mr-Geekman deleted the issue-1225 branch April 19, 2023 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants