Skip to content

Add default params_to_tune for math transforms #1233

Merged
merged 6 commits into from Apr 20, 2023
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 19, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1226.

Closing issues

Closes #1226.

d.a.bunin added 2 commits April 19, 2023 16:53
…nsform, MinTransform, MedianTransform, MeanTransform, StdTransform, MADTransform, MinMaxDifferenceTransform, QuantileTransform, BoxCoxTransform, YeoJohnsonTransform
…stScalerTransform, MinMaxScalerTransform, MaxAbsScalerTransform
@Mr-Geekman Mr-Geekman self-assigned this Apr 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@a1c19c8). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             automl-2.0   #1233   +/-   ##
============================================
  Coverage              ?   7.62%           
============================================
  Files                 ?     177           
  Lines                 ?   10699           
  Branches              ?       0           
============================================
  Hits                  ?     816           
  Misses                ?    9883           
  Partials              ?       0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

{
"with_centering": CategoricalDistribution([False, True]),
"with_scaling": CategoricalDistribution([False, True]),
"unit_variance": CategoricalDistribution([False, True]),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add quantile_range, it worked, but I don't really sure should we add it here because of the warning.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's skip it -- it already has reasonable default value

@github-actions github-actions bot temporarily deployed to pull request April 19, 2023 14:49 Inactive
{
"with_centering": CategoricalDistribution([False, True]),
"with_scaling": CategoricalDistribution([False, True]),
"unit_variance": CategoricalDistribution([False, True]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's skip it -- it already has reasonable default value

@github-actions github-actions bot temporarily deployed to pull request April 20, 2023 06:45 Inactive
@Mr-Geekman Mr-Geekman merged commit 5f1d074 into automl-2.0 Apr 20, 2023
13 checks passed
@Mr-Geekman Mr-Geekman deleted the issue-1226 branch April 20, 2023 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants