Skip to content

Change the default value to LinearRegression(positive=True) in the constructor of StackingEnsemble #1238

Merged
merged 3 commits into from Apr 21, 2023

Conversation

ostreech1997
Copy link
Collaborator

@ostreech1997 ostreech1997 commented Apr 20, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

See issue #846

Closing issues

Close issue #846

@ostreech1997 ostreech1997 changed the title Change the default value of Linear Regression in the constructor of StackingEnsemble (#846) Change the default value of Linear Regression in the constructor of StackingEnsemble Apr 20, 2023
@github-actions
Copy link

github-actions bot commented Apr 20, 2023

@github-actions github-actions bot temporarily deployed to pull request April 20, 2023 21:50 Inactive
@ostreech1997 ostreech1997 changed the title Change the default value of Linear Regression in the constructor of StackingEnsemble Change the default value to LinearRegression(positive=True) in the constructor of StackingEnsemble Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #1238 (0504587) into master (3cd565b) will decrease coverage by 30.39%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #1238       +/-   ##
===========================================
- Coverage   87.88%   57.49%   -30.39%     
===========================================
  Files         186      186               
  Lines       10621    10617        -4     
===========================================
- Hits         9334     6104     -3230     
- Misses       1287     4513     +3226     
Impacted Files Coverage Δ
etna/ensembles/stacking_ensemble.py 77.67% <100.00%> (-20.54%) ⬇️

... and 115 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 20, 2023 22:23 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 21, 2023 08:55 Inactive
@ostreech1997 ostreech1997 merged commit f06cd82 into master Apr 21, 2023
13 checks passed
@ostreech1997 ostreech1997 deleted the issue-846 branch April 21, 2023 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants