Skip to content

Add default params_to_tune for LabelEncoderTransform #1242

Merged
merged 5 commits into from Apr 25, 2023

Conversation

ostreech1997
Copy link
Collaborator

@ostreech1997 ostreech1997 commented Apr 25, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look at #1222

Closing issues

Closes issue #1222

@github-actions
Copy link

github-actions bot commented Apr 25, 2023

@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 10:33 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@5f1d074). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             automl-2.0    #1242   +/-   ##
=============================================
  Coverage              ?   87.83%           
=============================================
  Files                 ?      177           
  Lines                 ?    10710           
  Branches              ?        0           
=============================================
  Hits                  ?     9407           
  Misses                ?     1303           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 12:10 Inactive
@@ -130,6 +136,18 @@ def _get_column_name(self) -> str:
return self.out_column
return self.__repr__()

def params_to_tune(self) -> Dict[str, "BaseDistribution"]:
"""Get default grid for tuning hyperparameters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add line

This grid tunes only ``strategy`` parameter. Other parameters are expected to be set by the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like here

@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 14:04 Inactive
@ostreech1997 ostreech1997 merged commit ee74651 into automl-2.0 Apr 25, 2023
13 checks passed
@ostreech1997 ostreech1997 deleted the issue-1222 branch April 25, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants