Skip to content

Integrate Tune into Auto #1272

Merged
merged 8 commits into from Jun 6, 2023
Merged

Integrate Tune into Auto #1272

merged 8 commits into from Jun 6, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented May 29, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look at #1269.

Closing issues

Closes #1269.

@Mr-Geekman Mr-Geekman self-assigned this May 29, 2023
@github-actions
Copy link

github-actions bot commented May 29, 2023

@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 16:13 Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@f4b50fe). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff              @@
##             automl-2.0    #1272   +/-   ##
=============================================
  Coverage              ?   88.41%           
=============================================
  Files                 ?      186           
  Lines                 ?    11241           
  Branches              ?        0           
=============================================
  Hits                  ?     9939           
  Misses                ?     1302           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mr-Geekman Mr-Geekman requested a review from martins0n May 30, 2023 07:44
etna/auto/auto.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 08:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 13:53 Inactive
self._pool_optuna: Optional[Optuna] = None

root_folder = self.experiment_folder if self.experiment_folder is not None else ""
self._pool_folder = f"{root_folder}/pool"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If root_folder is None we'll get somenthing like /pool

Copy link
Contributor Author

@Mr-Geekman Mr-Geekman Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my intention. Is it bad? What name should we use in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in case of saving artifacts like files - we would save it to /pool folder and it's a potential risky situation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you suggest using pool instead of /pool if there is not self.experiment_folder? I'm ok with this.

etna/auto/auto.py Show resolved Hide resolved
etna/auto/auto.py Show resolved Hide resolved
@Mr-Geekman Mr-Geekman requested a review from martins0n June 5, 2023 10:40
@github-actions github-actions bot temporarily deployed to pull request June 6, 2023 09:15 Inactive
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mr-Geekman Mr-Geekman merged commit 439d5bf into automl-2.0 Jun 6, 2023
13 checks passed
@Mr-Geekman Mr-Geekman deleted the issue-1269 branch June 6, 2023 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants