Skip to content

Create notebook for Auto and Tune #1285

Merged
merged 8 commits into from Jun 14, 2023
Merged

Create notebook for Auto and Tune #1285

merged 8 commits into from Jun 14, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jun 13, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  1. Skip duplicates during optimization.
  2. Remove duplicates from top_k
  3. Look Create notebook for Auto and Tune #1274.

Closing issues

Closes #1274

@Mr-Geekman Mr-Geekman self-assigned this Jun 13, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@c343ab8). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff              @@
##             automl-2.0    #1285   +/-   ##
=============================================
  Coverage              ?   88.44%           
=============================================
  Files                 ?      186           
  Lines                 ?    11264           
  Branches              ?        0           
=============================================
  Hits                  ?     9962           
  Misses                ?     1302           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 13, 2023

@Mr-Geekman
Copy link
Contributor Author

Mr-Geekman commented Jun 13, 2023

There is a problem of big memory consumption of the notebook.

Setting gc_after_trial=True in a notebook doesn't solve a problem. Running script instead of the notebook doesn't solve it either.

@github-actions github-actions bot temporarily deployed to pull request June 13, 2023 07:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 13, 2023 07:41 Inactive
@review-notebook-app
Copy link

review-notebook-app bot commented Jun 13, 2023

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2023-06-13T11:50:23Z
----------------------------------------------------------------

Do we really want to keep the summary with duplicates?


Mr-Geekman commented on 2023-06-13T13:41:31Z
----------------------------------------------------------------

I think that summary should show all trials, it is strange to hide smth from the user.

@review-notebook-app
Copy link

review-notebook-app bot commented Jun 13, 2023

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2023-06-13T11:50:24Z
----------------------------------------------------------------

Let's hide this output


@review-notebook-app
Copy link

review-notebook-app bot commented Jun 13, 2023

View / edit / reply to this conversation on ReviewNB

martins0n commented on 2023-06-13T13:14:30Z
----------------------------------------------------------------

We should colaps these outputs


@review-notebook-app
Copy link

review-notebook-app bot commented Jun 13, 2023

View / edit / reply to this conversation on ReviewNB

martins0n commented on 2023-06-13T13:14:31Z
----------------------------------------------------------------

May be we should show only important columns


Mr-Geekman commented on 2023-06-13T13:39:33Z
----------------------------------------------------------------

I tried to do this in the next block. What do you mean by showing only important columns? Change existing summary method or limit columns in this block and don't show full sammary ?

@review-notebook-app
Copy link

review-notebook-app bot commented Jun 13, 2023

View / edit / reply to this conversation on ReviewNB

martins0n commented on 2023-06-13T13:14:32Z
----------------------------------------------------------------

It's not an easy task to find difference - we should show it.

Moreover if results ok we should add metrics on holdout to be more convincing


Mr-Geekman commented on 2023-06-13T13:48:02Z
----------------------------------------------------------------

It is easy to see at the summary by the column study. Top rows are with tune/ values, not with pool.I can emphasize it in the text.

Holdout is a good idea, I will try to add it.

examples/etna-auto.db Outdated Show resolved Hide resolved
@martins0n
Copy link
Contributor

#1285 (comment)

Did you find reason? In what place does it happen?

Copy link
Contributor Author

I tried to do this in the next block. What do you mean by showing only important columns? Change existing summary method or limit columns in this block and don't show full sammary ?


View entire conversation on ReviewNB

Copy link
Contributor Author

I think that summary should show all trials, it is strange to hide smth from the user.


View entire conversation on ReviewNB

Copy link
Contributor Author

It is easy to see at the summary by the column study. Top rows are with tune/ values, not with pool.I can emphasize it in the text.

Holdout is a good idea, I will try to add it.


View entire conversation on ReviewNB

@github-actions github-actions bot temporarily deployed to pull request June 14, 2023 07:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 14, 2023 11:50 Inactive
@Mr-Geekman Mr-Geekman merged commit 44c4b7e into automl-2.0 Jun 14, 2023
13 checks passed
@Mr-Geekman Mr-Geekman deleted the issue-1274 branch June 14, 2023 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants