Skip to content

Rewrite TimeSeriesImputerTransform to work without per-segment wrapper #1293

Merged
merged 7 commits into from Jun 22, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jun 21, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1287.

Closing issues

Closes #1287.

@Mr-Geekman Mr-Geekman self-assigned this Jun 21, 2023
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

@github-actions github-actions bot temporarily deployed to pull request June 21, 2023 09:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 21, 2023 10:36 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #1293 (c25d1fa) into master (bf66cd9) will increase coverage by 0.03%.
The diff coverage is 98.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
+ Coverage   88.57%   88.60%   +0.03%     
==========================================
  Files         189      189              
  Lines       11463    11485      +22     
==========================================
+ Hits        10153    10176      +23     
+ Misses       1310     1309       -1     
Impacted Files Coverage Δ
etna/transforms/missing_values/imputation.py 99.05% <98.70%> (+1.43%) ⬆️
etna/transforms/utils.py 90.90% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

d.a.bunin added 2 commits June 22, 2023 10:25
# Conflicts:
#	etna/transforms/missing_values/imputation.py
#	tests/test_transforms/test_missing_values/test_impute_transform.py
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 07:33 Inactive
@Mr-Geekman Mr-Geekman requested a review from brsnw250 June 22, 2023 07:38
@Mr-Geekman Mr-Geekman requested a review from brsnw250 June 22, 2023 08:55
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 08:56 Inactive
@Mr-Geekman Mr-Geekman requested a review from brsnw250 June 22, 2023 13:52
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 13:57 Inactive
@Mr-Geekman Mr-Geekman merged commit b1ec0f5 into master Jun 22, 2023
13 checks passed
@Mr-Geekman Mr-Geekman deleted the issue-1287 branch June 22, 2023 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TimeSeriesImputerTransform vectorized
3 participants