Skip to content

Add sorting by timestamp before the fit in catboost models #1337

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Add sorting by timestamp before the fit in catboost models #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
245ab0a
fix: add sorting by timestamp before the fit in catboost models
Jul 27, 2023
b7af7d3
chore: update changelog
Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed
-
-
- Add sorting by timestamp before the fit in `CatBoostPerSegmentModel` and `CatBoostMultiSegmentModel` ([#1337](https://github.com/tinkoff-ai/etna/pull/1337))
- Unify errors, warnings and checks in models ([#1312](https://github.com/tinkoff-ai/etna/pull/1312))
- Remove upper limitation on version of numba ([#1321](https://github.com/tinkoff-ai/etna/pull/1321))

Expand Down
1 change: 1 addition & 0 deletions etna/models/catboost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ def fit(self, df: pd.DataFrame, regressors: List[str]) -> "_CatBoostAdapter":
:
Fitted model
"""
df = df.sort_values(by="timestamp")
features = df.drop(columns=["timestamp", "target"])
target = df["target"]
train_pool = self._prepare_pool(features, target.values)
Expand Down