Skip to content

Add inverse_transform in *OutliersTransform #160

Merged
merged 18 commits into from Oct 12, 2021

Conversation

WinstonDovlatov
Copy link
Contributor

@WinstonDovlatov WinstonDovlatov commented Oct 8, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #129

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #160 (f442b68) into master (aa463ed) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   87.42%   87.27%   -0.15%     
==========================================
  Files          73       74       +1     
  Lines        3164     3286     +122     
==========================================
+ Hits         2766     2868     +102     
- Misses        398      418      +20     
Impacted Files Coverage Δ
etna/transforms/outliers.py 98.61% <100.00%> (+0.33%) ⬆️
etna/analysis/plotters.py 12.90% <0.00%> (-0.67%) ⬇️
etna/models/prophet.py 98.18% <0.00%> (-0.52%) ⬇️
etna/datasets/tsdataset.py 86.43% <0.00%> (-0.51%) ⬇️
etna/models/base.py 97.46% <0.00%> (ø)
etna/analysis/__init__.py 100.00% <0.00%> (ø)
etna/transforms/__init__.py 100.00% <0.00%> (ø)
etna/transforms/stl.py 93.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa463ed...f442b68. Read the comment docs.

@WinstonDovlatov WinstonDovlatov changed the title add inverse transform Add inverse_transform in *OutliersTransform Oct 8, 2021
@WinstonDovlatov WinstonDovlatov marked this pull request as ready for review October 9, 2021 13:38
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Outdated Show resolved Hide resolved
etna/transforms/outliers.py Show resolved Hide resolved
iKintosh
iKintosh previously approved these changes Oct 12, 2021
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update CHANGELOG.md please

@julia-shenshina julia-shenshina merged commit 610bb78 into master Oct 12, 2021
@iKintosh iKintosh deleted the add_inv_trans_outliers branch October 15, 2021 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inverse_transform in *OutliersTransform
5 participants