Skip to content

Instruction for custom model and transform creation #180

Merged
merged 3 commits into from Oct 12, 2021

Conversation

WinstonDovlatov
Copy link
Contributor

@WinstonDovlatov WinstonDovlatov commented Oct 12, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #76

iKintosh
iKintosh previously approved these changes Oct 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #180 (1cef838) into master (9c37a03) will decrease coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   87.78%   86.85%   -0.93%     
==========================================
  Files          75       75              
  Lines        3438     3432       -6     
==========================================
- Hits         3018     2981      -37     
- Misses        420      451      +31     
Impacted Files Coverage Δ
etna/models/nn/deepar.py 75.51% <0.00%> (-24.49%) ⬇️
etna/models/nn/tft.py 76.47% <0.00%> (-23.53%) ⬇️
etna/transforms/pytorch_forecasting.py 92.40% <0.00%> (-7.60%) ⬇️
etna/loggers/base.py 92.15% <0.00%> (-2.08%) ⬇️
etna/loggers/wandb_logger.py 33.33% <0.00%> (-1.50%) ⬇️
etna/loggers/console_logger.py 92.30% <0.00%> (-0.29%) ⬇️
etna/metrics/base.py 96.42% <0.00%> (-0.07%) ⬇️
etna/models/base.py 97.43% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c37a03...1cef838. Read the comment docs.

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WinstonDovlatov WinstonDovlatov merged commit 188de39 into master Oct 12, 2021
@iKintosh iKintosh deleted the custom_transf_and_model branch October 15, 2021 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create instruction for custom model and transform creation
3 participants