Skip to content

Add in_column to get_anomalies methods #199

Merged
merged 17 commits into from Oct 18, 2021
Merged

Conversation

WinstonDovlatov
Copy link
Contributor

@WinstonDovlatov WinstonDovlatov commented Oct 17, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#201

Closing issues

closes #177

@WinstonDovlatov WinstonDovlatov changed the title Add in_column and test Add in_column to get_anomalies methods Oct 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #199 (24f888b) into master (4a0db38) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   88.07%   88.32%   +0.24%     
==========================================
  Files          76       76              
  Lines        3523     3519       -4     
==========================================
+ Hits         3103     3108       +5     
+ Misses        420      411       -9     
Impacted Files Coverage Δ
.../analysis/outliers/confidence_interval_outliers.py 86.95% <ø> (ø)
etna/analysis/outliers/sequence_outliers.py 96.55% <ø> (ø)
etna/analysis/outliers/density_outliers.py 97.72% <100.00%> (ø)
etna/analysis/outliers/hist_outliers.py 77.07% <100.00%> (+5.73%) ⬆️
etna/analysis/outliers/median_outliers.py 95.83% <100.00%> (ø)
etna/transforms/outliers.py 98.78% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0db38...24f888b. Read the comment docs.

@WinstonDovlatov WinstonDovlatov marked this pull request as ready for review October 17, 2021 21:27
etna/transforms/outliers.py Show resolved Hide resolved
etna/transforms/outliers.py Show resolved Hide resolved
etna/transforms/outliers.py Show resolved Hide resolved
@WinstonDovlatov WinstonDovlatov merged commit 7ee0468 into master Oct 18, 2021
@iKintosh iKintosh deleted the in_column_to_anomalies branch November 18, 2021 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in_column to get_anomalies methods
4 participants