Skip to content

Add plot_backtest_interactive using plotly, add this to logging in backtest #225

Merged
merged 4 commits into from Oct 27, 2021

Conversation

Mr-Geekman
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

  • Add plot_bactest_interactive, that uses plotly
  • Add new plot to logging in WandbLogger

Related Issue

None.

Closing issues

None.

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Oct 26, 2021
@Mr-Geekman Mr-Geekman self-assigned this Oct 26, 2021
@Mr-Geekman Mr-Geekman added the bug Something isn't working label Oct 26, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review October 26, 2021 16:44
@codecov-commenter
Copy link

Codecov Report

Merging #225 (6cbb946) into master (db89a8e) will decrease coverage by 0.63%.
The diff coverage is 14.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   89.02%   88.38%   -0.64%     
==========================================
  Files          78       78              
  Lines        3698     3728      +30     
==========================================
+ Hits         3292     3295       +3     
- Misses        406      433      +27     
Impacted Files Coverage Δ
etna/analysis/plotters.py 12.43% <10.00%> (-0.48%) ⬇️
etna/loggers/wandb_logger.py 34.09% <33.33%> (-0.75%) ⬇️
etna/analysis/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db89a8e...6cbb946. Read the comment docs.

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit 9ba2f6d into master Oct 27, 2021
@martins0n martins0n deleted the ETNA-674 branch October 27, 2021 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants