Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 86.49% 86.54% +0.04%
==========================================
Files 89 90 +1
Lines 4244 4265 +21
==========================================
+ Hits 3671 3691 +20
- Misses 573 574 +1
Continue to review full report at Codecov.
|
from etna.analysis.feature_relevance.relevance_table import get_statistics_relevance_table | ||
|
||
|
||
class RelevanceTable(ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shell we also inherit from BaseMixin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
from etna.analysis.feature_relevance import StatisticsRelevanceTable | ||
|
||
|
||
def test_statistics_relevance_table(simple_df_relevance): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix the fixture typing in confest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues