Skip to content

RelevanceTable #249

Merged
merged 7 commits into from Nov 2, 2021
Merged

RelevanceTable #249

merged 7 commits into from Nov 2, 2021

Conversation

julia-shenshina
Copy link
Contributor

@julia-shenshina julia-shenshina commented Nov 2, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@julia-shenshina julia-shenshina marked this pull request as draft November 2, 2021 09:47
@julia-shenshina julia-shenshina self-assigned this Nov 2, 2021
@julia-shenshina julia-shenshina marked this pull request as ready for review November 2, 2021 10:07
@julia-shenshina julia-shenshina changed the title Etna 879 RelevanceTable Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #249 (7b685e6) into master (a51a363) will increase coverage by 0.04%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   86.49%   86.54%   +0.04%     
==========================================
  Files          89       90       +1     
  Lines        4244     4265      +21     
==========================================
+ Hits         3671     3691      +20     
- Misses        573      574       +1     
Impacted Files Coverage Δ
etna/analysis/feature_relevance/relevance.py 94.11% <94.11%> (ø)
etna/analysis/__init__.py 100.00% <100.00%> (ø)
etna/analysis/feature_relevance/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51a363...7b685e6. Read the comment docs.

from etna.analysis.feature_relevance.relevance_table import get_statistics_relevance_table


class RelevanceTable(ABC):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell we also inherit from BaseMixin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

from etna.analysis.feature_relevance import StatisticsRelevanceTable


def test_statistics_relevance_table(simple_df_relevance):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the fixture typing in confest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@julia-shenshina julia-shenshina merged commit 35db08a into master Nov 2, 2021
@iKintosh iKintosh deleted the ETNA-879 branch November 18, 2021 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants