Skip to content

Replace cycle over segments with vectorized expression in TSDataset._check_endings #264

Merged
merged 5 commits into from Nov 8, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Nov 8, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Replace cycle over segments with vectorized expression in TSDataset._check_endings_

Related Issue

#263.

Closing issues

Closes #263.

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Nov 8, 2021
@Mr-Geekman Mr-Geekman self-assigned this Nov 8, 2021
@Mr-Geekman Mr-Geekman changed the title Replace cycle over segments with vectorized expression in TSDataset._check_endings_ Replace cycle over segments with vectorized expression in TSDataset._check_endings Nov 8, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review November 8, 2021 14:46
@julia-shenshina julia-shenshina merged commit 14aab47 into master Nov 8, 2021
@iKintosh iKintosh deleted the issue-263 branch November 18, 2021 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of TSDataset._check_endings
2 participants