Add FilterFeaturesTransform
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2021 18:29
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 87.21% 87.63% +0.42%
==========================================
Files 94 95 +1
Lines 4653 4682 +29
==========================================
+ Hits 4058 4103 +45
+ Misses 595 579 -16
Continue to review full report at Codecov.
|
Ama16
reviewed
Nov 15, 2021
| def test_set_include_and_exclude(): | ||
| """Test that transform is not created with include and exclude.""" | ||
| with pytest.raises(ValueError, match="There should be exactly one option set: include or exclude"): | ||
| _ = FilterFeaturesTransform() |
| transform = FilterFeaturesTransform(include=include) | ||
| ts_with_features.fit_transform([transform]) | ||
| df_transformed = ts_with_features.df | ||
| expected_columns = set(ts_with_features.columns.get_level_values("feature")) |
| segments = ts_with_features.segments | ||
| for column in got_columns: | ||
| assert np.all( | ||
| df_transformed.loc[:, pd.IndexSlice[segments, column]] |
There was a problem hiding this comment.
df_transformed = ts_with_features.df , why you compare it?
There was a problem hiding this comment.
There was a bug earlier when values between columns mixed with each other, I wanted to unsure, it is not present here.
There was a problem hiding this comment.
There was a mistake, it will be fixed
julia-shenshina
previously approved these changes
Nov 15, 2021
Ama16
reviewed
Nov 16, 2021
etna/transforms/filter.py
Outdated
| """Filters features in each segment of the dataframe.""" | ||
|
|
||
| def __init__(self, include: Optional[Sequence[str]] = None, exclude: Optional[Sequence[str]] = None): | ||
| """Create instance of LagTransform. |
etna/transforms/filter.py
Outdated
| Parameters | ||
| ---------- | ||
| df: | ||
| dataframe with data to fit label encoder. |
Ama16
previously approved these changes
Nov 16, 2021
julia-shenshina
previously approved these changes
Nov 17, 2021
Ama16
previously approved these changes
Nov 17, 2021
# Conflicts: # CHANGELOG.md
Mr-Geekman
dismissed stale reviews from Ama16 and julia-shenshina
via
10b8e2f
added 3 commits
November 17, 2021 12:56
# Conflicts: # CHANGELOG.md # etna/transforms/__init__.py
julia-shenshina
approved these changes
Nov 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #271.
Related Issue
#271.
Closing issues
Closes #271.