Skip to content

add inverse transform as final step in forecast method; also rephrase… #316

Merged
merged 2 commits into from Nov 25, 2021
Merged

add inverse transform as final step in forecast method; also rephrase… #316

merged 2 commits into from Nov 25, 2021

Conversation

iKintosh
Copy link
Contributor

… _validate_backtest_dataset docstring

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

  • add inverse transform as final step in forecast method

Related Issue

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021 •
edited

Codecov Report

Merging #316 (907f7d9) into master (e66058f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files          96       96           
  Lines        4737     4738    +1     
=======================================
+ Hits         4157     4158    +1     
  Misses        580      580
Impacted Files Coverage Δ
etna/pipeline/pipeline.py 99.43% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66058f...907f7d9. Read the comment docs.

@iKintosh iKintosh marked this pull request as ready for review November 25, 2021 14:38
@iKintosh iKintosh merged commit c2070a1 into master Nov 25, 2021
Carlosbogo added a commit to Carlosbogo/etna that referenced this pull request Nov 27, 2021
@Carlosbogo
Squashed commit of the following:
b6210f0 
commit 381aeb3
Author: Carlosbg <bogomcar@gmail.com>
Date:   Sat Nov 27 14:23:16 2021 +0100

    Changes tests to keep consistency with tinkoff-ai#313

    Fixes tinkoff-ai#313 to close tinkoff-ai#290

commit c074d3b
Author: Andrey Alekseev <ilekseev@gmail.com>
Date:   Fri Nov 26 15:28:12 2021 +0300

    add acf plot; change eda notebook; (tinkoff-ai#318)

    * add acf plot; change eda notebook;

    * add changed to changelog

    Co-authored-by: an.alekseev <an.alekseev@tinkoff.ru>

commit 38623dc
Author: Mr-Geekman <36005824+Mr-Geekman@users.noreply.github.com>
Date:   Thu Nov 25 19:44:42 2021 +0300

    Add `duplicate_data` (tinkoff-ai#305)

    * Add utils file, function , tests for it

    * Add example for

    * Update changelog

    * Correct typos in docstring

    * Change default value for duplicate_data

commit c2070a1
Author: Andrey Alekseev <ilekseev@gmail.com>
Date:   Thu Nov 25 19:44:17 2021 +0300

    add inverse transform as final step in forecast method; also rephrase… (tinkoff-ai#316)

    * add inverse transform as final step in forecast method; also rephrase _validate_backtest_dataset docstring

    * add inverse transform as final step in fit method; change test; change example

    Co-authored-by: an.alekseev <an.alekseev@tinkoff.ru>

commit e66058f
Author: Andrey Alekseev <ilekseev@gmail.com>
Date:   Wed Nov 24 18:13:03 2021 +0300

    Parsing type hints in Sphinx documentation (tinkoff-ai#205)

    * update sphinx in order to parse type hints; make flake8-docstyle numpydocstyle compatible
    * update deps

commit e814219
Author: Martin Gabdushev <33594071+martins0n@users.noreply.github.com>
Date:   Wed Nov 24 18:10:04 2021 +0300

    :bomb: release 1.3.3 (tinkoff-ai#312)
@iKintosh iKintosh deleted the fix/pipeline_inverse_transform branch December 9, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julia-shenshina julia-shenshina julia-shenshina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iKintosh @codecov-commenter @julia-shenshina