Skip to content

Wandb Logger does not work unless pytorch is installed #340

Merged
merged 4 commits into from Dec 2, 2021
Merged

Conversation

martins0n
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

PLwandb logger initialization in getter only when it's needed

Related Issue

Closing issues

closes #335

@martins0n
Copy link
Contributor Author

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #340 (05fb5b5) into master (af51f3e) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   87.67%   87.67%   -0.01%     
==========================================
  Files          98       98              
  Lines        4820     4818       -2     
==========================================
- Hits         4226     4224       -2     
  Misses        594      594              
Impacted Files Coverage Δ
etna/loggers/wandb_logger.py 32.18% <0.00%> (-1.53%) ⬇️
etna/loggers/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af51f3e...05fb5b5. Read the comment docs.

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way you can revoke approve

etna/loggers/__init__.py Show resolved Hide resolved
etna/loggers/wandb_logger.py Show resolved Hide resolved
@martins0n martins0n merged commit dbaa95b into master Dec 2, 2021
@martins0n martins0n deleted the issue-335 branch December 2, 2021 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wandb Logger does not work unless pytorch is installed
3 participants