Skip to content

Add TSDatasets.__init__ regressors logic #357

Merged
merged 7 commits into from Dec 9, 2021

Conversation

Mr-Geekman
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #327.

Related Issue

#327.

Closing issues

Closes #327.

@Mr-Geekman Mr-Geekman self-assigned this Dec 6, 2021
else:
return sorted(list(known_future_unique))
elif len(known_future) > 0:
raise ValueError("There are is exogenous data to extract known future features")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

etna/datasets/tsdataset.py Show resolved Hide resolved
@Mr-Geekman
Copy link
Contributor Author

It was decided to add all literal to select all columns in df_exog to be regressors.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review December 7, 2021 06:57
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #357 (7f02531) into breaking_change/regressors (f0c2bfe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                      Coverage Diff                       @@
##           breaking_change/regressors     #357      +/-   ##
==============================================================
+ Coverage                       87.37%   87.39%   +0.02%     
==============================================================
  Files                              96       96              
  Lines                            4697     4706       +9     
==============================================================
+ Hits                             4104     4113       +9     
  Misses                            593      593              
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 92.82% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c2bfe...7f02531. Read the comment docs.

@martins0n martins0n merged commit 692ff58 into breaking_change/regressors Dec 9, 2021
@martins0n martins0n linked an issue Dec 9, 2021 that may be closed by this pull request
1 task
@iKintosh iKintosh deleted the issue-327 branch December 9, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSDatasets.__init__ regressors logic
4 participants