Skip to content

Change the way SARIMAXModel works with regressors #380

Merged
merged 2 commits into from Dec 15, 2021

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Dec 14, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #330

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Dec 14, 2021
@alex-hse-repository alex-hse-repository added this to the Regressors 2.0 milestone Dec 14, 2021
@alex-hse-repository alex-hse-repository self-assigned this Dec 14, 2021
@alex-hse-repository alex-hse-repository linked an issue Dec 14, 2021 that may be closed by this pull request
1 task
@alex-hse-repository alex-hse-repository changed the title Issue 330 Change the way SARIMAXModel works with regressors Dec 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (breaking_change/regressors@4130531). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             breaking_change/regressors     #380   +/-   ##
=============================================================
  Coverage                              ?   87.48%           
=============================================================
  Files                                 ?       96           
  Lines                                 ?     4723           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     4132           
  Misses                                ?      591           
  Partials                              ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4130531...869295f. Read the comment docs.

@julia-shenshina julia-shenshina merged commit 3dbc67a into breaking_change/regressors Dec 15, 2021
@martins0n martins0n deleted the issue-330 branch January 21, 2022 09:40
alex-hse-repository added a commit that referenced this pull request Jan 31, 2022
* Update _SARIMAX methods

* Update tests
alex-hse-repository added a commit that referenced this pull request Feb 1, 2022
* Update _SARIMAX methods

* Update tests
alex-hse-repository added a commit that referenced this pull request Feb 8, 2022
* Update _SARIMAX methods

* Update tests
alex-hse-repository added a commit that referenced this pull request Feb 14, 2022
* Update _SARIMAX methods

* Update tests
alex-hse-repository added a commit that referenced this pull request Feb 15, 2022
* Update _SARIMAX methods

* Update tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the way SARIMAXModel works with regressors
3 participants