Change method TSDataset.describe
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Geekman
changed the title
TSDatasetTSDataset.describe
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 87.22% 87.08% -0.15%
==========================================
Files 99 99
Lines 5003 5047 +44
==========================================
+ Hits 4364 4395 +31
- Misses 639 652 +13
Continue to review full report at Codecov.
|
etna/datasets/tsdataset.py
Outdated
| start_date end_date length num_missing num_segments num_exogs num_regressors freq | ||
| segments | ||
| segment_0 2021-06-01 2021-06-30 30 0 2 1 1 D | ||
| segment_1 2021-06-01 2021-06-30 30 0 2 1 1 D |
There was a problem hiding this comment.
looks like there are only four segment-specific columns: start_date, end_date, num_missing, length; another ones duplicate each other, don't they?
There was a problem hiding this comment.
I think we should change *_date -> *_timestamp
added 6 commits
December 24, 2021 18:22
# Conflicts: # CHANGELOG.md # tests/test_datasets/test_dataset.py
etna/datasets/tsdataset.py
Outdated
| Information about individual segments: | ||
| * start_timestamp: beginning of the segment, missing values in the beginning are ignored | ||
| * length: length according to start_date and end_date | ||
| * num_missing: number of missing variables between start_date and end_date |
There was a problem hiding this comment.
Suggested change
| * num_missing: number of missing variables between start_date and end_date | |
| * num_missing: number of missing variables between start_timestamp and end_timestamp |
etna/datasets/tsdataset.py
Outdated
|
|
||
| Information about individual segments: | ||
| * start_timestamp: beginning of the segment, missing values in the beginning are ignored | ||
| * length: length according to start_date and end_date |
There was a problem hiding this comment.
Suggested change
| * length: length according to start_date and end_date | |
| * length: length according to start_timestamp and end_timestamp |
etna/datasets/tsdataset.py
Outdated
| >>> ts = TSDataset(df_ts_format, df_exog=df_exog_ts_format, freq="D") | ||
| >>> ts.info() | ||
| <class 'etna.datasets.TSDataset'> | ||
| end_timestamp: 2021-06-30 00:00:00 |
There was a problem hiding this comment.
actually end_timestamp can be different for different series
I can run smth like
ts = TSDataset(...)
ts.info()
and should get valid result
etna/datasets/tsdataset.py
Outdated
| * start_timestamp: beginning of the segment, missing values in the beginning are ignored | ||
| * end_timestamp: ending of the segment, missing values are not ignored, common for all segments | ||
| * length: length according to start_date and end_date | ||
| * num_missing: number of missing variables between start_date and end_date |
There was a problem hiding this comment.
Suggested change
| * num_missing: number of missing variables between start_date and end_date | |
| * num_missing: number of missing variables between start_timestamp and end_timestamp |
etna/datasets/tsdataset.py
Outdated
| Method describes dataset in segment-wise fashion. Description columns: | ||
| * start_timestamp: beginning of the segment, missing values in the beginning are ignored | ||
| * end_timestamp: ending of the segment, missing values are not ignored, common for all segments | ||
| * length: length according to start_date and end_date |
There was a problem hiding this comment.
Suggested change
| * length: length according to start_date and end_date | |
| * length: length according to start_timestamp and end_timestamp |
added 4 commits
December 28, 2021 11:58
# Conflicts: # CHANGELOG.md
…> end_timestamps in docstrings
julia-shenshina
approved these changes
Dec 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #347
Related Issue
#347
Closing issues
Closes #347