Change the way Sklearn models works with regressors #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## breaking_change/regressors #440 +/- ##
=============================================================
Coverage ? 87.66%
=============================================================
Files ? 96
Lines ? 4757
Branches ? 0
=============================================================
Hits ? 4170
Misses ? 587
Partials ? 0 Continue to review full report at Codecov.
|
Mr-Geekman
reviewed
Jan 10, 2022
tests/test_models/test_sklearn.py
Outdated
| from etna.transforms.lags import LagTransform | ||
|
|
||
|
|
||
| @pytest.fixture() |
There was a problem hiding this comment.
We usually remove () in line @pytest.fixture
Mr-Geekman
reviewed
Jan 10, 2022
|
|
||
|
|
||
| @pytest.mark.parametrize("model", ([SklearnPerSegmentModel(regressor=LinearRegression())])) | ||
| def test_sklearn_persegment_model_saves_regressors(ts_with_regressors, model): |
There was a problem hiding this comment.
Add description to the test like "Test that ..."
alex-hse-repository
added a commit
that referenced
this pull request
Jan 31, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 1, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 8, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 14, 2022
alex-hse-repository
added a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #382