Skip to content

Add name property to Metric class #454

Merged
merged 3 commits into from Jan 14, 2022
Merged

Add name property to Metric class #454

merged 3 commits into from Jan 14, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jan 14, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #446

Related Issue

#446

Closing issues

Closes #446

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Jan 14, 2022
@Mr-Geekman Mr-Geekman self-assigned this Jan 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #454 (1fe9914) into master (4659990) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   87.79%   87.80%           
=======================================
  Files         114      114           
  Lines        5351     5354    +3     
=======================================
+ Hits         4698     4701    +3     
  Misses        653      653           
Impacted Files Coverage Δ
etna/metrics/base.py 96.61% <100.00%> (+0.18%) ⬆️
etna/pipeline/pipeline.py 97.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4659990...1fe9914. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review January 14, 2022 13:08
@julia-shenshina julia-shenshina merged commit 94eb069 into master Jan 14, 2022
@julia-shenshina julia-shenshina deleted the issue-446 branch January 17, 2022 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric representation in backtest
3 participants