[BUG] Sarima not working with non defualt params #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 87.99% 87.98% -0.02%
==========================================
Files 115 115
Lines 5448 5441 -7
==========================================
- Hits 4794 4787 -7
Misses 654 654
Continue to review full report at Codecov.
|
Mr-Geekman
reviewed
Jan 21, 2022
Co-authored-by: Mr-Geekman <36005824+Mr-Geekman@users.noreply.github.com>
julia-shenshina
previously approved these changes
Jan 21, 2022
| @@ -55,7 +55,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - | |||
| - | |||
| - | |||
| - | |||
| - SARIMAX parameters fix ([#459](https://github.com/tinkoff-ai/etna/pull/459)) | |||
There was a problem hiding this comment.
looks like a merge problem?
There was a problem hiding this comment.
No, It's example how to properly use placeholders. We should fill them at random place to minimize probability of merge conflicts
julia-shenshina
approved these changes
Jan 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457
**IMPORTANT: Please do not create a Pull Request without creating an issue first.**
## Before submitting (must do checklist)
- [x] Did you read the [contribution guide](https://github.com/tinkoff\-ai/etna/blob/master/CONTRIBUTING.md\)?
- [x] Did you update the docs? We use Numpy format for all the methods and classes.
- [x] Did you write any new necessary tests?
- [ x] Did you update the [CHANGELOG](https://github.com/tinkoff\-ai/etna/blob/master/CHANGELOG.md\)?
<!-- For CHANGELOG separate each item in unreleased section by blank line to reduce collisions -->
## Type of Change
<!-- Mark with an `x` all the checkboxes that apply (like `[x]`) -->
- [ ] Examples / docs / tutorials / contributors update
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Improvement (non-breaking change which improves an existing feature)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Proposed Changes
<!-- Add a more detailed description of the changes if needed.
No need for typos and docs improvements -->
## Related Issue
<!-- Link Issue here. -->
## Closing issues
<!-- Link Issue you are closing here.
Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). -->
closes #457