Skip to content

[BUG] Cant make forecasting with pipelines, data with nans, and Imputers #466 #473

Merged
merged 6 commits into from Feb 2, 2022

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Feb 1, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #466

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #473 (f45b682) into master (0ed9c58) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   87.81%   87.83%   +0.01%     
==========================================
  Files         115      115              
  Lines        5450     5450              
==========================================
+ Hits         4786     4787       +1     
+ Misses        664      663       -1     
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 89.49% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed9c58...f45b682. Read the comment docs.

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a temporal solution.
In the future there will be only two ending checks.

  1. In the init with a warning.
  2. At the end of a make_future method which will result in error if endings are inconsistent. This will ensure that all models work with the data equally.

@iKintosh iKintosh enabled auto-merge (squash) February 2, 2022 12:56
@martins0n
Copy link
Contributor Author

This seems like a temporal solution. In the future there will be only two ending checks.

  1. In the init with a warning.
  2. At the end of a make_future method which will result in error if endings are inconsistent. This will ensure that all models work with the data equally.

Could you create issue, please?

@iKintosh iKintosh merged commit c1f49ed into master Feb 2, 2022
@iKintosh iKintosh deleted the issue-466 branch March 22, 2022 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cant make forecasting with pipelines, data with nans, and Imputers
3 participants