Conversation
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 87.29% 87.24% -0.05%
==========================================
Files 118 118
Lines 5698 5701 +3
==========================================
Hits 4974 4974
- Misses 724 727 +3
Continue to review full report at Codecov.
|
for metric_key, metric_value in metrics_dict.items(): | ||
self.experiment.summary[metric_key] = metric_value | ||
summary.update(metrics_dict) | ||
self.experiment.log(summary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we log only once? Instead of several times as we did before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because wandb.summary is one final state,
and one wandb.log -- is one state vs multiple wandb.log -- multiple states.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues