Skip to content

Fix/wandb log summary #535

Merged
merged 11 commits into from Feb 24, 2022
Merged

Fix/wandb log summary #535

merged 11 commits into from Feb 24, 2022

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Feb 15, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #535 (4278133) into master (dda1455) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   87.29%   87.24%   -0.05%     
==========================================
  Files         118      118              
  Lines        5698     5701       +3     
==========================================
  Hits         4974     4974              
- Misses        724      727       +3     
Impacted Files Coverage Δ
etna/loggers/wandb_logger.py 33.33% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda1455...4278133. Read the comment docs.

iKintosh
iKintosh previously approved these changes Feb 15, 2022
for metric_key, metric_value in metrics_dict.items():
self.experiment.summary[metric_key] = metric_value
summary.update(metrics_dict)
self.experiment.log(summary)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we log only once? Instead of several times as we did before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because wandb.summary is one final state,
and one wandb.log -- is one state vs multiple wandb.log -- multiple states.

@iKintosh iKintosh merged commit f487d39 into master Feb 24, 2022
@iKintosh iKintosh deleted the fix/wandb_log_summary branch February 24, 2022 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants