Skip to content

Create PerSegmentBaseModel, PerSegmentPredictionIntervalModel, PerSegmentModel #537

Merged
merged 3 commits into from Feb 17, 2022
Merged

Create PerSegmentBaseModel, PerSegmentPredictionIntervalModel, PerSegmentModel #537

merged 3 commits into from Feb 17, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Feb 16, 2022 •
edited

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #506

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Feb 16, 2022
@alex-hse-repository alex-hse-repository self-assigned this Feb 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022 •
edited

Codecov Report

Merging #537 (9f0cf37) into master (faafc15) will decrease coverage by 0.34%.
The diff coverage is 82.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   87.83%   87.49%   -0.35%     
==========================================
  Files         118      118              
  Lines        5704     5740      +36     
==========================================
+ Hits         5010     5022      +12     
- Misses        694      718      +24
Impacted Files Coverage Δ
etna/models/base.py 77.44% <81.33%> (-16.38%) ⬇️
etna/models/prophet.py 98.38% <100.00%> (ø)
etna/models/sarimax.py 95.54% <100.00%> (ø)
etna/models/sklearn.py 96.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faafc15...9f0cf37. Read the comment docs.

iKintosh
iKintosh reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some question considering Prophet and SARIMAX

etna/models/base.py Outdated
)
result_list.append(segment_predict)

# need real case to test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still relevant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ideas)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it then

etna/models/sarimax.py Show resolved Hide resolved
iKintosh
iKintosh reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Let's remove deprecated comments and let's merge.

@alex-hse-repository alex-hse-repository merged commit a7ed4f9 into master Feb 17, 2022
@iKintosh iKintosh deleted the issue-506 branch March 22, 2022 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iKintosh iKintosh iKintosh approved these changes

@Mr-Geekman Mr-Geekman Awaiting requested review from Mr-Geekman

Assignees

@alex-hse-repository alex-hse-repository

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create PerSegmentBaseModel, PerSegmentPredictionIntervalModel, PerSegmentModel
3 participants
@alex-hse-repository @codecov-commenter @iKintosh