Add logging to TSDataset.make_future
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2022 13:29
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 118 118
Lines 5692 5693 +1
=======================================
+ Hits 4968 4969 +1
Misses 724 724
Continue to review full report at Codecov.
|
etna/datasets/tsdataset.py
Outdated
| @@ -288,6 +288,7 @@ def make_future(self, future_steps: int) -> "TSDataset": | |||
|
|
|||
| if self.transforms is not None: | |||
| for transform in self.transforms: | |||
| tslogger.log(f"Transform {transform.__class__.__name__} is applied to dataset") | |||
There was a problem hiding this comment.
why not transform.__repr__()?
if you have smth like transforms=[LagTransform(in_column="target", ...), LagTransform(in_column="exog", ...)] there are two different transforms of the same class
There was a problem hiding this comment.
Here I just repeat code from TSDataset.transform. If wee want this, I can change it in both places and in TSDataset.fit_transform too.
julia-shenshina
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Look #553.
Related Issue
#553.
Closing issues
Closes #553.