Skip to content

Update get_started section in README #569

Merged
merged 15 commits into from Mar 4, 2022
Merged

Update get_started section in README #569

merged 15 commits into from Mar 4, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Feb 22, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #491.

Related Issue

#491.

Closing issues

Closes #491.

@Mr-Geekman Mr-Geekman added the documentation Improvements or additions to documentation label Feb 22, 2022
@Mr-Geekman Mr-Geekman self-assigned this Feb 22, 2022
@Mr-Geekman Mr-Geekman changed the title Add new get_started in README, add blank lines for consistency Add new get_started in README Feb 22, 2022
@Mr-Geekman Mr-Geekman changed the title Add new get_started in README Update get_started section in README Feb 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #569 (fd4ae29) into master (a8fcfa3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files         119      119           
  Lines        5739     5739           
=======================================
  Hits         4982     4982           
  Misses        757      757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fcfa3...fd4ae29. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 108 to 114
from etna.transforms import DateFlagsTransform
from etna.transforms import DensityOutliersTransform
from etna.transforms import FourierTransform
from etna.transforms import LagTransform
from etna.transforms import LinearTrendTransform
from etna.transforms import SegmentEncoderTransform
from etna.transforms import TimeSeriesImputerTransform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from etna.transforms import DateFlagsTransform
from etna.transforms import DensityOutliersTransform
from etna.transforms import FourierTransform
from etna.transforms import LagTransform
from etna.transforms import LinearTrendTransform
from etna.transforms import SegmentEncoderTransform
from etna.transforms import TimeSeriesImputerTransform
from etna.transforms import DateFlagsTransform, DensityOutliersTransform, FourierTransform, LagTransform, \
LinearTrendTransform, SegmentEncoderTransform, TimeSeriesImputerTransform

README.md Outdated
Comment on lines 122 to 128
DateFlagsTransform(
day_number_in_week=True,
day_number_in_month=True,
is_weekend=True,
week_number_in_month=True,
out_column="date_flag",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DateFlagsTransform(
day_number_in_week=True,
day_number_in_month=True,
is_weekend=True,
week_number_in_month=True,
out_column="date_flag",
),
DateFlagsTransform(is_weekend=True, week_number_in_month=True, out_column="date_flag"),

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iKintosh iKintosh enabled auto-merge (squash) March 4, 2022 12:08
@iKintosh iKintosh merged commit 745a28a into master Mar 4, 2022
@Mr-Geekman Mr-Geekman deleted the issue-491 branch March 4, 2022 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: update get started section
3 participants