Skip to content

Create BasePipeline #578

Merged
merged 19 commits into from Mar 9, 2022
Merged

Create BasePipeline #578

merged 19 commits into from Mar 9, 2022

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Mar 1, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #562

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Mar 1, 2022
@alex-hse-repository alex-hse-repository self-assigned this Mar 1, 2022
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs some fixes.

etna/pipeline/__init__.py Outdated Show resolved Hide resolved
etna/pipeline/base.py Show resolved Hide resolved
etna/ensembles/voting_ensemble.py Outdated Show resolved Hide resolved
etna/pipeline/autoregressive_pipeline.py Show resolved Hide resolved
etna/pipeline/autoregressive_pipeline.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #578 (a91b03f) into master (9ea2a81) will decrease coverage by 0.08%.
The diff coverage is 95.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   86.80%   86.72%   -0.09%     
==========================================
  Files         119      119              
  Lines        5739     5733       -6     
==========================================
- Hits         4982     4972      -10     
- Misses        757      761       +4     
Impacted Files Coverage Δ
etna/ensembles/voting_ensemble.py 97.56% <85.71%> (-2.44%) ⬇️
etna/ensembles/stacking_ensemble.py 96.87% <88.88%> (-1.09%) ⬇️
etna/pipeline/autoregressive_pipeline.py 95.65% <92.30%> (-2.18%) ⬇️
etna/pipeline/pipeline.py 96.96% <92.85%> (-0.43%) ⬇️
etna/pipeline/base.py 95.78% <96.36%> (+3.89%) ⬆️
etna/ensembles/base.py 100.00% <100.00%> (ø)
etna/models/base.py 88.00% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea2a81...a91b03f. Read the comment docs.

Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository merged commit a8507c0 into master Mar 9, 2022
@iKintosh iKintosh deleted the issue-562 branch March 22, 2022 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create BasePipeline
4 participants