Skip to content

fix plot_trend bug #617

Merged
merged 5 commits into from Mar 22, 2022
Merged

fix plot_trend bug #617

merged 5 commits into from Mar 22, 2022

Conversation

iKintosh
Copy link
Contributor

@iKintosh iKintosh commented Mar 22, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closes #612

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #617 (201a2ac) into master (067f6ad) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   84.12%   84.55%   +0.43%     
==========================================
  Files         118      118              
  Lines        5964     5964              
==========================================
+ Hits         5017     5043      +26     
+ Misses        947      921      -26     
Impacted Files Coverage Δ
etna/analysis/plotters.py 22.14% <100.00%> (+6.06%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more



@pytest.mark.parametrize("poly_degree", (1, 2))
def test_plot_trend_theilsen(poly_degree, example_tsdf):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we unite this test with previous? They are inherited from the same base class.

@iKintosh
Copy link
Contributor Author

test_plot_trend

fig_1
fig_2

test_plot_bin_seg

fig_3

test_plot_stl

fig_4

@iKintosh iKintosh merged commit 576b87e into master Mar 22, 2022
@iKintosh iKintosh deleted the bugfix/plot_trend branch March 22, 2022 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] plot_trend does not work
4 participants