Skip to content

fix issue 616 #623

Merged
merged 6 commits into from
Mar 29, 2022
Merged

fix issue 616 #623

merged 6 commits into from
Mar 29, 2022

Conversation

julia-shenshina
Copy link
Contributor

@julia-shenshina julia-shenshina commented Mar 23, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #616

@julia-shenshina julia-shenshina marked this pull request as draft March 23, 2022 14:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #623 (b9090db) into master (0a7851d) will increase coverage by 0.05%.
The diff coverage is 93.18%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   83.96%   84.01%   +0.05%     
==========================================
  Files         118      118              
  Lines        6087     6120      +33     
==========================================
+ Hits         5111     5142      +31     
- Misses        976      978       +2     
Impacted Files Coverage Δ
etna/models/base.py 87.73% <84.21%> (-0.27%) ⬇️
etna/models/__init__.py 100.00% <100.00%> (ø)
etna/models/catboost.py 100.00% <100.00%> (ø)
etna/models/holt_winters.py 98.82% <100.00%> (+0.04%) ⬆️
etna/models/prophet.py 98.80% <100.00%> (+0.04%) ⬆️
etna/models/sarimax.py 94.01% <100.00%> (+0.15%) ⬆️
etna/models/seasonal_ma.py 97.36% <100.00%> (+0.22%) ⬆️
etna/models/sklearn.py 94.44% <100.00%> (+0.50%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@julia-shenshina julia-shenshina marked this pull request as ready for review March 28, 2022 09:19
@julia-shenshina julia-shenshina changed the title [Draft] fix issue 616 fix issue 616 Mar 28, 2022
@martins0n martins0n linked an issue Mar 29, 2022 that may be closed by this pull request
1 task
@iKintosh iKintosh merged commit ae3095c into master Mar 29, 2022
@iKintosh iKintosh deleted the issue616 branch March 29, 2022 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] get_model is not working correctly
3 participants