Conversation
🚀 Deployed on https://deploy-preview-689--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 83.79% 83.54% -0.25%
==========================================
Files 119 119
Lines 6479 6479
==========================================
- Hits 5429 5413 -16
- Misses 1050 1066 +16
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@@ -1,5 +1,5 @@ | |||
[flake8] | |||
ignore = F, E203, W605, E501, W503, D100, D104 | |||
ignore = F, E203, W605, E501, W503, D100, D104, C408 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you decide to ignore C408?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in cases like this
Lines 133 to 139 in be1b719
trainer_kwargs = dict( | |
logger=tslogger.pl_loggers, | |
max_epochs=self.max_epochs, | |
gpus=self.gpus, | |
checkpoint_callback=False, | |
gradient_clip_val=self.gradient_clip_val, | |
) |
It would be easier to read dict(key=value) approach, than {"key": value} in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think?
2827670
to
eb46e31
Compare
eb46e31
to
1c48b91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues