Skip to content

add flake8-comprehentions #689

Merged
merged 6 commits into from May 26, 2022
Merged

Conversation

iKintosh
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@github-actions
Copy link

github-actions bot commented May 13, 2022

🚀 Deployed on https://deploy-preview-689--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 13, 2022 10:16 Inactive
@iKintosh iKintosh self-assigned this May 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #689 (eb46e31) into master (be1b719) will decrease coverage by 0.24%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   83.79%   83.54%   -0.25%     
==========================================
  Files         119      119              
  Lines        6479     6479              
==========================================
- Hits         5429     5413      -16     
- Misses       1050     1066      +16     
Impacted Files Coverage Δ
etna/analysis/plotters.py 21.27% <0.00%> (ø)
etna/transforms/timestamp/special_days.py 97.59% <0.00%> (ø)
etna/datasets/tsdataset.py 90.08% <100.00%> (ø)
etna/ensembles/base.py 100.00% <100.00%> (ø)
etna/transforms/feature_selection/base.py 100.00% <100.00%> (ø)
etna/transforms/missing_values/resample.py 96.42% <100.00%> (ø)
etna/transforms/utils.py 100.00% <100.00%> (ø)
etna/libs/tsfresh/distribution.py 33.33% <0.00%> (-50.01%) ⬇️
etna/libs/tsfresh/significance_tests.py 18.84% <0.00%> (-13.05%) ⬇️
etna/libs/tsfresh/relevance.py 72.38% <0.00%> (-3.81%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Mr-Geekman
Mr-Geekman previously approved these changes May 13, 2022
@@ -1,5 +1,5 @@
[flake8]
ignore = F, E203, W605, E501, W503, D100, D104
ignore = F, E203, W605, E501, W503, D100, D104, C408
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you decide to ignore C408?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in cases like this

trainer_kwargs = dict(
logger=tslogger.pl_loggers,
max_epochs=self.max_epochs,
gpus=self.gpus,
checkpoint_callback=False,
gradient_clip_val=self.gradient_clip_val,
)

It would be easier to read dict(key=value) approach, than {"key": value} in my opinion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

@iKintosh iKintosh marked this pull request as draft May 20, 2022 18:31
@github-actions github-actions bot temporarily deployed to pull request May 20, 2022 18:57 Inactive
@iKintosh iKintosh marked this pull request as ready for review May 25, 2022 16:16
@github-actions github-actions bot temporarily deployed to pull request May 25, 2022 16:23 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository merged commit dd3175c into master May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants