Skip to content

Style fixes for EDA methods #705

Merged
merged 11 commits into from
May 27, 2022
Merged

Style fixes for EDA methods #705

merged 11 commits into from
May 27, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented May 23, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #701.

Related Issue

#701.

Closing issues

Closes #701.

@Mr-Geekman Mr-Geekman self-assigned this May 23, 2022
@Mr-Geekman Mr-Geekman added documentation Improvements or additions to documentation enhancement New feature or request labels May 23, 2022
@github-actions
Copy link

github-actions bot commented May 23, 2022

🚀 Deployed on https://deploy-preview-705--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 23, 2022 13:13 Inactive
@alex-hse-repository
Copy link
Collaborator

Why don't we have grid in notebook with outliers?

CHANGELOG.md Outdated
@@ -26,7 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
-
-
-
- Style fixes for EDA methods ([#705](https://github.com/tinkoff-ai/etna/pull/705))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you list the exact changes

@github-actions github-actions bot temporarily deployed to pull request May 27, 2022 07:22 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #705 (b637d92) into master (dd3175c) will decrease coverage by 0.32%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
- Coverage   83.80%   83.48%   -0.33%     
==========================================
  Files         120      120              
  Lines        6558     6576      +18     
==========================================
- Hits         5496     5490       -6     
- Misses       1062     1086      +24     
Impacted Files Coverage Δ
etna/analysis/eda_utils.py 53.06% <0.00%> (-1.17%) ⬇️
etna/datasets/tsdataset.py 89.83% <0.00%> (-0.25%) ⬇️
etna/analysis/plotters.py 20.85% <11.11%> (-0.25%) ⬇️
etna/analysis/utils.py 100.00% <100.00%> (ø)
etna/models/nn/tft.py 91.80% <0.00%> (-8.20%) ⬇️
etna/transforms/nn/pytorch_forecasting.py 90.47% <0.00%> (-4.77%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository merged commit c086567 into master May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some style fixes
3 participants