Skip to content

Fix making backtest if all segments start with NaNs #728

Merged
merged 4 commits into from Jun 6, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jun 2, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Look #725.

Related Issue

#725.

Closing issues

Closes #725.

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Jun 2, 2022
@Mr-Geekman Mr-Geekman self-assigned this Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

🚀 Deployed on https://deploy-preview-728--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 2, 2022 14:15 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #728 (e7f0482) into master (d85c7f0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         120      120           
  Lines        6629     6629           
=======================================
  Hits         5547     5547           
  Misses       1082     1082           
Impacted Files Coverage Δ
etna/pipeline/base.py 94.44% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we also need test that run the backtest on dataset with nans in the begging and FoldMask logic

etna/pipeline/base.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 08:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 09:03 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository enabled auto-merge (squash) June 6, 2022 09:13
@alex-hse-repository alex-hse-repository merged commit 418ed17 into master Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fails to make backtest if all segments start with NaNs
3 participants