Skip to content

Tbas adapter #734

Merged
merged 28 commits into from Jun 8, 2022
Merged

Tbas adapter #734

merged 28 commits into from Jun 8, 2022

Conversation

scanhex12
Copy link
Collaborator

@scanhex12 scanhex12 commented Jun 3, 2022

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #678

@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 12:55 Inactive
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

🚀 Deployed on https://deploy-preview-734--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 13:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 13:11 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #734 (4879636) into master (f9fb07c) will increase coverage by 0.12%.
The diff coverage is 95.55%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   83.58%   83.71%   +0.12%     
==========================================
  Files         121      122       +1     
  Lines        6654     6699      +45     
==========================================
+ Hits         5562     5608      +46     
+ Misses       1092     1091       -1     
Impacted Files Coverage Δ
etna/models/tbats.py 95.34% <95.34%> (ø)
etna/models/__init__.py 100.00% <100.00%> (ø)
etna/core/mixins.py 95.65% <0.00%> (+13.04%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 13:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 13:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 13:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 13:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 14:00 Inactive
@julia-shenshina julia-shenshina self-requested a review June 3, 2022 14:27
@github-actions github-actions bot temporarily deployed to pull request June 3, 2022 14:48 Inactive
@scanhex12 scanhex12 closed this Jun 3, 2022
@scanhex12 scanhex12 reopened this Jun 3, 2022
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⭐

Some small fixes:

  • you should update CHANGELOG.md (section Unreleased -> Added)
  • fill the header of the PR please:
    • choose task type
    • add issue to closes issue section - it is important to close the corresponding issue when merge the PR

etna/models/tbats.py Outdated Show resolved Hide resolved
etna/models/tbats.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 5, 2022 20:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2022 20:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 05:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 06:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 7, 2022 12:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 8, 2022 12:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 8, 2022 13:03 Inactive
etna/models/tbats.py Outdated Show resolved Hide resolved
etna/models/tbats.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 8, 2022 13:17 Inactive
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥

@julia-shenshina julia-shenshina merged commit 4fa63bc into master Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BATS and TBATS model adapters
3 participants