issue-726-fix

[DBcreator]

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

• Did you read the contribution guide?
• Did you update the docs? We use Numpy format for all the methods and classes.
• Did you write any new necessary tests?
• Did you update the CHANGELOG?

Type of Change

• Examples / docs / tutorials / contributors update
• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves an existing feature)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

closes #726

[github-actions]

🚀 Deployed on https://deploy-preview-753--etna-docs.netlify.app

[codecov-commenter]

Codecov Report

Merging #753 (4074311) into master (e33f583) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   83.66%   83.47%   -0.20%     
==========================================
  Files         120      122       +2     
  Lines        6631     6736     +105     
==========================================
+ Hits         5548     5623      +75     
- Misses       1083     1113      +30     

Impacted Files	Coverage Δ
etna/analysis/plotters.py	25.98% <0.00%> (-0.87%)	⬇️
etna/metrics/functional_metrics.py	85.00% <0.00%> (-1.67%)	⬇️
etna/models/nn/tft.py	100.00% <0.00%> (ø)
etna/pipeline/base.py	94.46% <0.00%> (ø)
etna/metrics/metrics.py	100.00% <0.00%> (ø)
etna/models/__init__.py	100.00% <0.00%> (ø)
etna/metrics/__init__.py	100.00% <0.00%> (ø)
etna/models/nn/deepar.py	100.00% <0.00%> (ø)
etna/transforms/decomposition/stl.py	94.44% <0.00%> (ø)
etna/transforms/feature_selection/base.py	100.00% <0.00%> (ø)
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[alex-hse-repository]

Well done, but need some fixes👍

1. Update the changelog
2. Link the issue to the PR in "Closing issues" section like this "Closes #."
3. Assign yourself to the issue and to the PR
4. Fix all the comments I left

Also, it is a good practice to set more informative title to the PR to make it easier to guess what was this PR about

[alex-hse-repository]

I guess when you resolve conflicts this will disappear, but it is strange

[alex-hse-repository]

Start the description with the capital letter
We actually don't have a convention about it, however all of them should start with the same type of the letter

[alex-hse-repository]

Looks good👍

• Fix the docstring in one more place
• Also you need to resolve conflicts in Changelog, you can do it with the GitHub UI