Skip to content

Add tests that every current model can predict in-sample, out-sample with gap #786

Merged
merged 7 commits into from
Jul 12, 2022
Merged

Add tests that every current model can predict in-sample, out-sample with gap #786

merged 7 commits into from
Jul 12, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jul 7, 2022 •
edited
Loading

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #783.

Closing issues

Closes #783.

@Mr-Geekman Mr-Geekman self-assigned this Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited
Loading

🚀 Deployed on https://deploy-preview-786--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 7, 2022 14:13 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #786 (34e1dbd) into master (687a1a9) will increase coverage by 0.24%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   83.56%   83.81%   +0.24%     
==========================================
  Files         123      123              
  Lines        6895     6895              
==========================================
+ Hits         5762     5779      +17     
+ Misses       1133     1116      -17
Impacted Files Coverage Δ
etna/models/base.py 87.73% <50.00%> (ø)
etna/core/mixins.py 100.00% <0.00%> (+4.34%) ⬆️
etna/models/catboost.py 100.00% <0.00%> (+22.85%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot temporarily deployed to pull request July 8, 2022 08:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2022 08:37 Inactive
@Mr-Geekman Mr-Geekman mentioned this pull request Jul 8, 2022
Closed
1 task
martins0n
martins0n suggested changes Jul 8, 2022
View reviewed changes
etna/models/base.py Outdated Show resolved Hide resolved
tests/test_models/test_common.py Outdated Show resolved Hide resolved
tests/test_models/test_common.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 8, 2022 16:12 Inactive
This was referenced Jul 8, 2022
Closed
Closed
@github-actions github-actions bot temporarily deployed to pull request July 11, 2022 07:17 Inactive
martins0n
martins0n suggested changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@martins0n martins0n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename test_common to test_inference_mod or something else.

@github-actions github-actions bot temporarily deployed to pull request July 12, 2022 07:01 Inactive
@martins0n martins0n enabled auto-merge (squash) July 12, 2022 07:12
martins0n
martins0n approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit 0bb7a64 into master Jul 12, 2022
@martins0n martins0n deleted the issue-783 branch July 12, 2022 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martins0n martins0n martins0n approved these changes

Assignees

@Mr-Geekman Mr-Geekman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure that every current model can predict in-sample, out-sample with gap
3 participants
@Mr-Geekman @codecov-commenter @martins0n