Skip to content

DeadlineMovingAverageModel #827

Merged
merged 18 commits into from
Aug 5, 2022
Merged

DeadlineMovingAverageModel #827

merged 18 commits into from
Aug 5, 2022

Conversation

DBcreator
Copy link
Contributor

@DBcreator DBcreator commented Jul 29, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #801

@github-actions
Copy link

github-actions bot commented Jul 29, 2022

🚀 Deployed on https://deploy-preview-827--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 29, 2022 20:23 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #827 (0387d4d) into master (5efc8f5) will increase coverage by 0.10%.
The diff coverage is 90.99%.

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
+ Coverage   84.34%   84.44%   +0.10%     
==========================================
  Files         126      128       +2     
  Lines        7238     7349     +111     
==========================================
+ Hits         6105     6206     +101     
- Misses       1133     1143      +10     
Impacted Files Coverage Δ
etna/models/deadline_ma.py 87.30% <87.30%> (ø)
etna/ensembles/direct_ensemble.py 95.65% <95.65%> (ø)
etna/ensembles/__init__.py 100.00% <100.00%> (ø)
etna/models/__init__.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

etna/models/deadline_ma.py Outdated Show resolved Hide resolved
window: int
Number of values taken for forecast for each point.
seasonality: str
Monthly or annual seasonality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add available seasonalities to the docs please

etna/models/deadline_ma.py Show resolved Hide resolved
etna/models/deadline_ma.py Outdated Show resolved Hide resolved
etna/models/deadline_ma.py Outdated Show resolved Hide resolved
etna/models/deadline_ma.py Outdated Show resolved Hide resolved
tests/test_models/test_deadline_ma.py Outdated Show resolved Hide resolved
tests/test_models/test_deadline_ma.py Outdated Show resolved Hide resolved
etna/models/__init__.py Outdated Show resolved Hide resolved
etna/models/deadline_ma.py Outdated Show resolved Hide resolved
@julia-shenshina
Copy link
Contributor

update CHANGELOG please

@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 11:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 13:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 14:02 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
etna/models/deadline_ma.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 20:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2022 20:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 3, 2022 14:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 3, 2022 14:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 3, 2022 15:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 3, 2022 15:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 3, 2022 17:30 Inactive
julia-shenshina
julia-shenshina previously approved these changes Aug 5, 2022
@github-actions github-actions bot temporarily deployed to pull request August 5, 2022 09:27 Inactive
@julia-shenshina julia-shenshina merged commit 71a19db into master Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DeadlineMovingAverageModel
3 participants