Skip to content

FIX: script and cron action yml #856

Merged
merged 3 commits into from
Aug 16, 2022
Merged

FIX: script and cron action yml #856

merged 3 commits into from
Aug 16, 2022

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Aug 15, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #773

@github-actions
Copy link

github-actions bot commented Aug 15, 2022

🚀 Deployed on https://deploy-preview-856--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 15, 2022 14:56 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #856 (73f78b2) into master (5a6bdcc) will decrease coverage by 35.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #856       +/-   ##
===========================================
- Coverage   84.66%   49.36%   -35.30%     
===========================================
  Files         130      130               
  Lines        7414     7414               
===========================================
- Hits         6277     3660     -2617     
- Misses       1137     3754     +2617     
Impacted Files Coverage Δ
etna/commands/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
etna/commands/backtest_command.py 0.00% <0.00%> (-97.06%) ⬇️
etna/commands/forecast_command.py 0.00% <0.00%> (-94.88%) ⬇️
etna/models/utils.py 12.50% <0.00%> (-87.50%) ⬇️
etna/commands/__main__.py 0.00% <0.00%> (-87.50%) ⬇️
etna/libs/pmdarima_utils/arima.py 16.00% <0.00%> (-84.00%) ⬇️
etna/commands/resolvers.py 0.00% <0.00%> (-80.00%) ⬇️
etna/analysis/outliers/density_outliers.py 22.44% <0.00%> (-75.52%) ⬇️
etna/datasets/datasets_generation.py 27.02% <0.00%> (-72.98%) ⬇️
etna/transforms/timestamp/time_flags.py 27.02% <0.00%> (-72.98%) ⬇️
... and 79 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request August 15, 2022 15:06 Inactive
@martins0n martins0n self-assigned this Aug 15, 2022
@Mr-Geekman Mr-Geekman self-requested a review August 16, 2022 07:45

def get_list_to_remove(leave_last_n_images: int, image_versions: list):
image_versions = sorted(
image_versions, key=lambda x: datetime.datetime.strptime(x["created_at"], "%Y-%m-%dT%H:%M:%SZ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it iso-format? Probably we can use datetime.datetime.fromisoformat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z at the end

def remove_images(image_versions: list):
for image in image_versions:
print(f"Removing {image['url']}")
subprocess.run(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need such a strange way of running this code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason non-get empty requests return 422 error.
This is workaround.

cli/cli#3937

@martins0n martins0n merged commit 0198d11 into master Aug 16, 2022
@martins0n martins0n deleted the issue-773 branch August 16, 2022 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CICD: untaged docker image cleaner
3 participants