FIX: script and cron action yml #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-856--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
===========================================
- Coverage 84.66% 49.36% -35.30%
===========================================
Files 130 130
Lines 7414 7414
===========================================
- Hits 6277 3660 -2617
- Misses 1137 3754 +2617
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mr-Geekman
reviewed
Aug 16, 2022
|
|
||
| def get_list_to_remove(leave_last_n_images: int, image_versions: list): | ||
| image_versions = sorted( | ||
| image_versions, key=lambda x: datetime.datetime.strptime(x["created_at"], "%Y-%m-%dT%H:%M:%SZ") |
There was a problem hiding this comment.
Isn't it iso-format? Probably we can use datetime.datetime.fromisoformat.
Mr-Geekman
reviewed
Aug 16, 2022
| def remove_images(image_versions: list): | ||
| for image in image_versions: | ||
| print(f"Removing {image['url']}") | ||
| subprocess.run( |
There was a problem hiding this comment.
Why do we need such a strange way of running this code?
There was a problem hiding this comment.
For some reason non-get empty requests return 422 error.
This is workaround.
Mr-Geekman
approved these changes
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #773