Skip to content

Notebook with forecasting strategies #863

Merged
merged 25 commits into from Sep 1, 2022

Conversation

scanhex12
Copy link
Collaborator

@scanhex12 scanhex12 commented Aug 18, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

#825

@github-actions
Copy link

github-actions bot commented Aug 18, 2022

🚀 Deployed on https://deploy-preview-863--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 09:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 11:26 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #863 (a2ecf4a) into master (14a2da5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   84.90%   84.90%   -0.01%     
==========================================
  Files         133      133              
  Lines        7548     7545       -3     
==========================================
- Hits         6409     6406       -3     
  Misses       1139     1139              
Impacted Files Coverage Δ
etna/models/utils.py 100.00% <0.00%> (ø)
etna/models/nn/mlp.py 100.00% <0.00%> (ø)
etna/models/nn/rnn.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 11:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 11:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 18, 2022 12:16 Inactive
@scanhex12 scanhex12 self-assigned this Aug 18, 2022
examples/forecasting_strategies.ipynb Outdated Show resolved Hide resolved
examples/forecasting_strategies.ipynb Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 15:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 19, 2022 16:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 21, 2022 17:49 Inactive
@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:31Z
----------------------------------------------------------------

"Pipelines don't accepts" -> "Pipeline doesn't accept"


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:32Z
----------------------------------------------------------------

"Forecast the future " -> "Forecasting the future "


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:33Z
----------------------------------------------------------------

Leave only "The computational time growth with the number of base pipelines." in the second point


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:33Z
----------------------------------------------------------------

  1. Remove the (2) and add "Input models(horizons)" to (1) in each "model" occasion (i.e. model(horizon))
  2. "This function can be comfortable ... " -> "Let's build the ensemble from the previous section using assemble_pipelines"

@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:34Z
----------------------------------------------------------------

Pipelines generation process looks now a bit simpler, is't it? Now it's time to create DirectEnsemble out of them:


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:35Z
----------------------------------------------------------------

Let's check that the forecasts has not changed:


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:35Z
----------------------------------------------------------------

Why do you need to drop sth here?


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 30, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-30T10:08:36Z
----------------------------------------------------------------

Make sure you use the same number of lags everywhere!


@github-actions github-actions bot temporarily deployed to pull request August 30, 2022 11:13 Inactive
@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:24Z
----------------------------------------------------------------

  1. Recursive -> Recursive (and so on)
  2. Direct: uses separate model to forecast each time subsegment
  3. DirRec: uses a separate model to forecast each time subsegment, fitting the next model on the train set extended with the forecasts of previous models
  4. MIMO: uses a single multi-output model
  5. DIRMO: MIMO + DirREC
  6. The first two of these were implemented -> The first two of these strategies are available


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:24Z
----------------------------------------------------------------

Let's add constant NUMBER_OF_LAGS = 21 (3 weeks) and use it everywhere to build lags + Edit the numbers in text


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:25Z
----------------------------------------------------------------

AutoregressivePipeline -> AutoregressivePipeline


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:26Z
----------------------------------------------------------------

  1. AutoRegressive pipeline is pipeline -> AutoregressivePipeline is a pipeline + make sure you highlighted all the occurrence of Pipeline/AutoregressivePipeline/DirectEnsemble
  2. "Could be slow ..." -> "Could work slow ..."
  3. forecastings -> forecasting, forecastins -> forecasts

@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:27Z
----------------------------------------------------------------

  1. "from horizon to 40" -> "from horizon to 34"
  2. Pipeline and DirectEnsemble -> Pipeline and DirectEnsemble
  3. Pipeline -> Pipeline


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:28Z
----------------------------------------------------------------

  1. forecastings -> forecasting
  2. DirectEnsemble -> DirectEnsemble
  3. Forecasting the future,
  4. a base pipeline / the current forecasted


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:28Z
----------------------------------------------------------------

  1. little bit shorter,
  2. sequence of sequences 
  3. function will transformate in -> function will put

@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:29Z
----------------------------------------------------------------

isn't


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:30Z
----------------------------------------------------------------

In this notebook,


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 31, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T05:25:31Z
----------------------------------------------------------------

Sort the results by SMAPE


@github-actions github-actions bot temporarily deployed to pull request August 31, 2022 07:13 Inactive
@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T11:55:22Z
----------------------------------------------------------------

AutoRegressive pipeline -> AutoRegressivePipeline


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-08-31T11:55:23Z
----------------------------------------------------------------

7 to 7 + number_of_lags -> 7 to 7 + number_of_lags


@github-actions github-actions bot temporarily deployed to pull request August 31, 2022 13:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 1, 2022 07:00 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository merged commit 8a8cefa into master Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants