Skip to content

Fix native networks to work with generated future equals to horizon #936

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 12, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  1. Pass horizon instead of decoder_length in forecast.
  2. Call make_future with decoder_length in pipeline
  3. Fix tests for native networks.

Closing issues

Closes #925.

@Mr-Geekman Mr-Geekman self-assigned this Sep 12, 2022
@github-actions
Copy link

github-actions bot commented Sep 12, 2022

🚀 Deployed on https://deploy-preview-936--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 12, 2022 09:42 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #936 (c754a50) into master (9aede87) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   84.99%   84.99%           
=======================================
  Files         133      133           
  Lines        7611     7611           
=======================================
  Hits         6469     6469           
  Misses       1142     1142           
Impacted Files Coverage Δ
etna/models/base.py 87.59% <ø> (ø)
etna/pipeline/pipeline.py 97.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martins0n martins0n self-requested a review September 13, 2022 07:43
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit cb19d87 into master Sep 13, 2022
@martins0n martins0n deleted the issue-925 branch September 13, 2022 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Native networks don't work with generated future equals to horizon
3 participants