Skip to content

issue-937 fix #941

Merged
merged 6 commits into from Sep 15, 2022
Merged

issue-937 fix #941

merged 6 commits into from Sep 15, 2022

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Sep 14, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #937

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

🚀 Deployed on https://deploy-preview-941--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 14, 2022 16:24 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #941 (51b14ca) into master (a02d2d6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   85.00%   85.01%   +0.01%     
==========================================
  Files         133      133              
  Lines        7614     7620       +6     
==========================================
+ Hits         6472     6478       +6     
  Misses       1142     1142              
Impacted Files Coverage Δ
etna/core/mixins.py 95.71% <100.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

etna/core/mixins.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Mr-Geekman Mr-Geekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer questions above.

@github-actions github-actions bot temporarily deployed to pull request September 15, 2022 09:55 Inactive
@martins0n martins0n self-assigned this Sep 15, 2022
@github-actions github-actions bot temporarily deployed to pull request September 15, 2022 10:29 Inactive
etna/core/mixins.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request September 15, 2022 11:43 Inactive
Mr-Geekman
Mr-Geekman previously approved these changes Sep 15, 2022
Copy link
Contributor

@Mr-Geekman Mr-Geekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix to pass lint stage and everything else is fine.

@martins0n martins0n merged commit 49bf818 into master Sep 15, 2022
@martins0n martins0n deleted the issue-937 branch September 15, 2022 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] to_dict with callables in arguments
3 participants