Skip to content

Etna-760 #96

Merged
merged 39 commits into from Sep 28, 2021
Merged

Etna-760 #96

merged 39 commits into from Sep 28, 2021

Conversation

WinstonDovlatov
Copy link
Contributor

@WinstonDovlatov WinstonDovlatov commented Sep 27, 2021

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #96 (db16c15) into master (d45201d) will increase coverage by 0.16%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   87.77%   87.94%   +0.16%     
==========================================
  Files          54       55       +1     
  Lines        2478     2521      +43     
==========================================
+ Hits         2175     2217      +42     
- Misses        303      304       +1     
Impacted Files Coverage Δ
etna/analysis/outliers/sequence_outliers.py 96.55% <96.55%> (ø)
etna/analysis/__init__.py 100.00% <100.00%> (ø)
etna/analysis/outliers/__init__.py 100.00% <100.00%> (ø)
etna/transforms/__init__.py 100.00% <100.00%> (ø)
etna/transforms/outliers.py 98.24% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45201d...db16c15. Read the comment docs.

@julia-shenshina
Copy link
Contributor

could you please add SAXOutliersTransform(OutliersTransform)?
example: https://github.com/tinkoff-ai/etna-ts/blob/master/etna/transforms/outliers.py

CHANGELOG.md Outdated Show resolved Hide resolved
@WinstonDovlatov WinstonDovlatov changed the title Draft: Etna 760 Etna 760 Sep 27, 2021
@WinstonDovlatov WinstonDovlatov changed the title Etna 760 Etna-760 Sep 27, 2021
Co-authored-by: Julia Shenshina <yuliya.shenshina@phystech.edu>
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@julia-shenshina julia-shenshina merged commit 1073870 into master Sep 28, 2021
@iKintosh iKintosh deleted the ETNA-760 branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants