Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pluginSubscription is not called for deleted subscriptions #744

Closed
gabriel-vasile opened this issue Apr 14, 2022 · 2 comments
Closed

pluginSubscription is not called for deleted subscriptions #744

gabriel-vasile opened this issue Apr 14, 2022 · 2 comments
Labels
bug

Comments

@gabriel-vasile
Copy link
Contributor

tinode version: master

gabriel@tbook:~/tmp/chat/server$ grep -r pluginSubscription
plugins.go:func pluginSubscription(sub *types.Subscription, action int) {
topic.go:				pluginSubscription(sub, plgActCreate)
topic.go:				pluginSubscription(sub, plgActUpd)
topic.go:			pluginSubscription(sub, plgActCreate)
or-else added a commit that referenced this issue Apr 15, 2022
@or-else
fix for #744
e935093
@or-else
Copy link
Contributor

or-else commented Apr 15, 2022

This should fix it e935093
Please verify. Thanks.

@or-else
Copy link
Contributor

or-else commented Apr 26, 2022

Released in https://github.com/tinode/chat/releases/tag/v0.18.5-rc1

@or-else or-else closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@or-else @gabriel-vasile