Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building with modern Ruby versions #9

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

skipkayhil
Copy link
Contributor

Update Bundler version for Ruby 3.2

Previously, Bundler would use version 1.14.6 specified in the
Gemfile.lock. However, this version of Bundler uses the #untaint method
which was removed in Ruby 3.2.

To fix this, the locked version of Bundler has been updated. The version
chosen is the last 2.3.x release as 2.4 drops support for Rubyies 2.3 -
2.5. If dropping support for EoL Rubies is not an issue then the Bundler
version could be upgraded further.


Replace #exists? with #exist?

The #exists? method has been deprecated since Ruby 2.1.0 and was finally
removed in Ruby 3.0

Previously, Bundler would use version 1.14.6 specified in the
Gemfile.lock. However, this version of Bundler uses the #untaint method
which was removed in Ruby 3.2.

To fix this, the locked version of Bundler has been updated. The version
chosen is the last 2.3.x release as 2.4 drops support for Rubyies 2.3 -
2.5. If dropping support for EoL Rubies is not an issue then the Bundler
version could be upgraded further.
The #exists? method has been deprecated since Ruby 2.1.0 and was finally
removed in Ruby 3.0
@skipkayhil skipkayhil requested a review from a team as a code owner January 26, 2023 21:35
@skipkayhil
Copy link
Contributor Author

@tinted-theming anything I can do to move this forward?

@skipkayhil
Copy link
Contributor Author

@belak @JamyGolden @obahareth hey all, happy to help maintain this repo if there's interest. I'd really love to be able to keep using this builder and I recognize everyone's time can be spread pretty thinly across projects

@JamyGolden
Copy link
Member

Hey @skipkayhil. I didn't get a notification when you created this in Jan 😞

Currently the builder that supports the latest builder spec is base16-builder-go and the binaries are provided on the repo too. We'd be happy to have you on board and working on something in the project! If you specifically want to work on this ruby builder (even though we have an up to date builder), then go for it! I can add you as a maintainer to the repo. If you want to be involved in other things (you could do both too), then let me know!

@belak belak merged commit 72935c4 into tinted-theming:master Nov 16, 2023
@belak
Copy link
Member

belak commented Nov 16, 2023

This looks good to me, though I don't know ruby very well - if you want to update and maintain the Ruby builder, we'd love to have your help!

@skipkayhil
Copy link
Contributor Author

That would be awesome! Don't want to go too crazy with changes but I would love to package this as a gem so that it could be easily installed/run without having to clone the repo

@skipkayhil skipkayhil deleted the fix-modern-ruby branch November 20, 2023 00:00
@JamyGolden
Copy link
Member

Great! I've sent an maintainer invite for this repository @skipkayhil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants