You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that this project is invoking abi-to-sol by asking for Solidity v0.8.9, which differs from this project's solc dependency version of ^0.8.15. This probably isn't a big deal, but in the future it might make sense to align this generateSolidity({ solidityVersion }) field more formally with the version of solc that's running in this shell.
Note that this field accepts a semver range, and abi-to-sol seeks to output Solidity that is valid across all versions in that range... so you can probably start by doing a require("../../package.json").dependencies["solc"] or such and just use that instead of hardcoding some kind of version or version range literal.
The text was updated successfully, but these errors were encountered:
Oh, but you allow users to specify a pragma solidity statement to select a different solc version...
In that case, you probably want to capture that user-specified range and pass that to abi-to-sol. This should work fine (except for weird situations where users want >0.4.0 <0.9.0 or some range that's overly broad and contains unreconcilable syntax forms)
I noticed that this project is invoking abi-to-sol by asking for Solidity v0.8.9, which differs from this project's solc dependency version of
^0.8.15
. This probably isn't a big deal, but in the future it might make sense to align thisgenerateSolidity({ solidityVersion })
field more formally with the version of solc that's running in this shell.Note that this field accepts a semver range, and abi-to-sol seeks to output Solidity that is valid across all versions in that range... so you can probably start by doing a
require("../../package.json").dependencies["solc"]
or such and just use that instead of hardcoding some kind of version or version range literal.The text was updated successfully, but these errors were encountered: