Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response: Drop the use of EqualReader for TransferEncoding::Identity #183

Merged

Conversation

rawler
Copy link
Collaborator

@rawler rawler commented Sep 19, 2020

It's purpose is unclear, and it causes the entire reader to be consumed,
even when client has disconnected and won't get the content.

If the application needs to flush the reader for some side-effect, that
can still be achieved by the application itself.

Resolves: #182

@rawler rawler force-pushed the drop-equalreader-from-identity-transfer branch 3 times, most recently from 6b91f63 to 1632d33 Compare Sep 19, 2020
@rawler rawler requested review from tomaka and frewsxcv Sep 21, 2020
@dheijl
Copy link

dheijl commented Dec 5, 2020

I'd like to support this pull request. I can't see a rationale for the existence of EqualReader either.
It effectively prevents streaming without chunking (even though chunking was invented for the purpose of streaming, some devices can't handle chunking when streaming).
If there is a reason for having it, I still think it should be possible to disable it.

It's purpose is unclear, and it causes the entire reader to be consumed,
even when client has disconnected and won't get the content.

If the application needs to flush the reader for some side-effect, that
can still be achieved by the application itself.
@rawler rawler force-pushed the drop-equalreader-from-identity-transfer branch from 1632d33 to 9aa589e Compare Dec 29, 2020
@rawler
Copy link
Collaborator Author

rawler commented Dec 29, 2020

Since I have endorsement, and long time without review, I'll merge this.

@rawler rawler merged commit 5ada7c1 into tiny-http:master Dec 29, 2020
1 check passed
@rawler rawler deleted the drop-equalreader-from-identity-transfer branch Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants