Skip installing Ansible as part of bundle creation #1500
Conversation
We used to use Ansible to download external Ansible roles. As of #1469, we no longer have external Ansible roles, so we can skip installing Ansible as part of creating the TinyPilot install bundle.
Automated comment from CodeApprove ➜⏳ @jdeanwallace please review this Pull Request |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
Oh nice catch, thanks! LGTM.
In: bundler/create-bundle:
> Line 78
mkdir "${ANSIBLE_ROLES_DIR}"
I think we'll still need to clear out any previous Ansible role directories (i.e., roles/ansible-role-tinypilot and roles/ansible-role-ustreamer) because if we run create-bundle multiple times (as might be the case when using the install-from-source script) then the previous Ansible role directories would clash with the current directories when we copy them in below.
👀 @mtlynch it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: bundler/create-bundle:
> Line 78
mkdir "${ANSIBLE_ROLES_DIR}"
Ah, right! Fixed.
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
We used to use Ansible to download external Ansible roles. As of #1469, we no longer have external Ansible roles, so we can skip installing Ansible as part of creating the TinyPilot install bundle.
I don't think we need to test manually, as the bundles are identical modulo timestamps (which I removed for this comparison):
https://gist.github.com/mtlynch/c65d8ad745f750cc6dd1b8ac93955650
This change cuts about 90s from the bundle build workflow.
Before
After