-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Debian package using CircleCI ARM executor #1588
Conversation
… build instructions.
Automated comment from CodeApprove ➜⏳ @mtlynch please review this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated comment from CodeApprove ➜
LGTM, thanks!
In: Discussion
Remember on future PRs to add a PR description. I added on for expediency here, as I'm eager to see this go in.
In: CONTRIBUTING.md:
The sudo
shouldn't be necessary in any of these. This can happen if your user account isn't in the right Docker group.
I pushed a change to adjust these instructions in 4c3e0ce
👀 @db39 it's your turn please take a look
I think the only change we need is to preserve the |
@jotaen4tinypilot, @jdeanwallace - Just a heads up that this is a slight change to our dev workflow. CircleCI will build Debian packages and TinyPilot bundles on every commit. On Pro, we still only build microSD images on |
Resolves #1584
We've been using Docker+QEMU to emulate 32-bit ARM on AMD64, but this PR switches to ARM-native CircleCI instances, which skips the emulation.
This achieves a speedup on building Debian packages from about 4m down to about 70s.
Because Debian package building is fast again, we're changing our CI workflow to build a Debian package on every commit rather than just on
master
or just when we manually trigger it.