Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercom-Android 3.1.0 broke compat with SDK v23 #75

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Intercom-Android 3.1.0 broke compat with SDK v23 #75

merged 1 commit into from
Mar 6, 2017

Conversation

cesarkawakami
Copy link
Contributor

Intercom-Android has just released version 3.1.0. In our brief compat testing, we've noticed it's now requiring android:TextAppearance.Material.Widget.Button.Borderless.Colored which doesn't seem to be available in the SDK version used by the latest version of React Native.

This commit pins the Intercom SDK version to 3.0.+ so things keep working.

Maybe this isn't the right fix and the Intercom SDK should fix their release so that the version change reflects backwards compatibility characteristics, but for now it's the best we have.

@browniefed
Copy link
Contributor

Thank you.

@browniefed browniefed merged commit 6a1dbed into tinycreative:master Mar 6, 2017
@browniefed
Copy link
Contributor

published as v5.7.0

@cesarkawakami
Copy link
Contributor Author

Many thanks!

@ronocod
Copy link

ronocod commented Mar 14, 2017

Some extra context on this:

The build.gradle files that React Native generate for Android use compileSdkVersion 23 and targetSdkVersion 23. It's common for apps that don't work well with newer SDK features to use an older targetSdkVersion, but they should always use the latest stable compileSdkVersion available. Using an old compileSdkVersion can cause a lot of build issues, usually related to the Support Library like this one. React Native seems to have been using compileSdkVersion 23 for quite some time, and I'm surprised they haven't updated as it's quite old now.

I'll file an issue on the React Native repo for their usage of the old compileSdkVersion, but even if they update it then existing build.gradle files in React Native projects won't get updated. I've added a comment to this issue explaining how to update your build.gradle file and fix this issue. With this fix you should be able to use 3.1.0 without any problems.

@ronocod
Copy link

ronocod commented Mar 14, 2017

I've filed an issue on the React Native repo about this: facebook/react-native#12929

@browniefed
Copy link
Contributor

@ronocod Thanks! This is great information to know. Hopefully something is done about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants